[SYCL] [libdevice] Add vector overloads of ConvertBFloat16ToFINTEL and ConvertFToBFloat16INTEL #14085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-tools-reviewers friendly ping! |
asudarsa
approved these changes
Jun 10, 2024
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| }).wait(); | ||
|
|
||
| if (err) | ||
| std::cout << "failed\n"; |
There was a problem hiding this comment.
if there is a future change in the source that causes this test to fail someday, it'll be more work for whoever catches that ticket. Make the failure output more explicit. At minimum output "failed on host" and "failed on device". And if you know of anything else that might be useful to some unlucky co-worker, maybe include that too.
There was a problem hiding this comment.
Sure. I'll improve the test output.
There was a problem hiding this comment.
Actually, after looking at the test again, the test will currently output something like:
bfloat16[4] -> float[4] conversion on device... passed/failed
or
float[4] -> bfloat16[4] -> float[4] conversion on host.... passed/failed
for device and host respectively. There's a std::cout before queue.submit() which will output the type of conversion being performed along where the conversion takes place (host/device).
cperkinsintel
approved these changes
Jun 12, 2024
bader
reviewed
Jun 13, 2024
| }).wait(); | ||
|
|
||
| if (err) | ||
| std::cout << "failed\n"; |
There was a problem hiding this comment.
Shouldn't this go to std::cerr instead of std::cout?
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…d ConvertFToBFloat16INTEL (intel#14085) This PR adds vector overloads of `ConvertBFloat16ToFINTEL` and `ConvertFToBFloat16INTEL` to libdevice (SPEC: https://spec.oneapi.io/level-zero/latest/core/SPIRV.html#bfloat16-conversions) and a wrapper around it (`BF16VecToFloatVec` and `FloatVecToBF16Vec`) in `ext::oneapi::detail`. These overloads are intended to optimize BFloat16 `marray`, `vec` operations, for which we currently do element-by-element `bfloat16 -> float -> bfloat16` conversions.
againull
pushed a commit
that referenced
this pull request
Jun 21, 2024
…cl::vec` of `bfloat16` type to that of other data types (#14105) Follow-up of and blocked by: #14085 After this change: On host, conversion between `vec<bfloat16>` and `vec<float>` will happen element-by-element. While on device, we'll use Spirv intrinsic `OpConvertFToBF16INTEL` and `OpConvertBF16ToFINTEL` (https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bfloat16_conversion.asciidoc) for vector conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds vector overloads of
ConvertBFloat16ToFINTELandConvertFToBFloat16INTELto libdevice (SPEC: https://spec.oneapi.io/level-zero/latest/core/SPIRV.html#bfloat16-conversions) and a wrapper around it (BF16VecToFloatVecandFloatVecToBF16Vec) inext::oneapi::detail.These overloads are intended to optimize BFloat16
marray,vecoperations, for which we currently do element-by-elementbfloat16 -> float -> bfloat16conversions.